Owen Rudge : shell32: Implement SHGetImageList and remove todo_wine from imagelist tests.

Nikolay Sivov bunglehead at gmail.com
Tue Nov 17 09:55:43 CST 2009


Hi, Owen. There's a mistake here.

+    hNew = ImageList_Duplicate(iImageList == SHIL_LARGE ? hLarge : hSmall);
+
+    /* Get the interface for the new image list */
+    if (hNew)
+    {
+        ret = HIMAGELIST_QueryInterface(hNew, riid, ppv);
+
+        if (!SUCCEEDED(ret))
+            ImageList_Destroy(hNew);
+    }

After duplication hNew already has refcount == 1, after
HIMAGELIST_QueryInterface is goes to 2, and it isn't what you want. To
hide checking riid just remove condition before ImageList_Destroy.



More information about the wine-devel mailing list