services.exe: Reduce Registry access to KEY_READ or MAXIMUM_ALLOWED wherever possible (try 2)
Alexandre Julliard
julliard at winehq.org
Mon Nov 30 09:51:35 CST 2009
Paul Chitescu <paulc at voip.null.ro> writes:
> @@ -569,11 +569,11 @@ DWORD svcctl_ChangeServiceConfigW(
> new_entry.config.lpDisplayName = strdupW(lpDisplayName);
> }
>
> - *service->service_entry = new_entry;
> - save_service_config(service->service_entry);
> + err = save_service_config(&new_entry);
> + if (ERROR_SUCCESS == err) *service->service_entry = new_entry;
> service_unlock(service->service_entry);
This can't work, the strings have been freed already.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list