msvcrt: dont overwrite the standard streams (with test, try 5)
André Hentschel
nerv at dawncrow.de
Sun Sep 6 09:45:37 CDT 2009
Eric Pouech schrieb:
> Hi André
> a couple of comments to your patch
always welcome!
> IMO, we should also test that cbReserved2 is >= sizeof(unsigned)
> otherwise we'd be in trouble
maybe you had something like that patch in mind:
http://www.winehq.org/pipermail/wine-patches/2009-August/077766.html
it checks if the size makes sense
> you should do it without user32. instead of doing this
>> + while (MsgWaitForMultipleObjects( 1, &proc.hProcess, FALSE,
>> INFINITE, QS_ALLINPUT ) != 0)
>> + {
>> + while (PeekMessage(&msg, 0, 0, 0, PM_REMOVE))
>> DispatchMessageA(&msg);
>> + }
>>
> you could simply wait for the child process to terminate
> A+
>
of course, your right, fixed that.
--
Best Regards, André Hentschel
More information about the wine-devel
mailing list