[PATCH] wined3d: Display state in state_undefined
titan.costa at wanadoo.fr
Tue Feb 16 12:32:19 CST 2010
Henri Verbeet a écrit :
> On 16 February 2010 13:45, Christian Costa <titan.costa at wanadoo.fr> wrote:
>> Ok. What about doing the following :
>> - when state is 0, don't print any message because it's normal
>> - when state is not 0, print the state to have a meaningfull message
> No, if you see that message at all, something is broken, that's why
> it's an ERR. If state is non-zero even more is broken, but that's
> pretty much irrelevant at that point.
So we should never enter this function at all. Right ?
And what do you mean by "something is broken" ? Are you talking about
wined3d code ?
That said I don't understand why we should not display the state. The
fact is we entered this code
and it seems, according to you, that knowing the state which produces
the error message makes the difference.
More information about the wine-devel