[1/7] avifile: Initial test data and simple test for avifil32 depends

Julius Schwartzenberg julius.schwartzenberg at gmail.com
Fri Jan 1 14:18:05 CST 2010

Paul Vriens wrote:
> On 12/30/2009 03:21 AM, Julius Schwartzenberg wrote:
>> This patch depends on Detlef Riekenberg's patch from June 2008 and
>> expects it to have been applied:
>> http://www.winehq.org/pipermail/wine-patches/2008-June/056310.html
>> It was not committed due to bug 14085:
>> http://bugs.winehq.org/show_bug.cgi?id=14085
> Can't you just submit that initial test framework with the 3 imports (if 
> all 3 are indeed needed)? The bug will of course not be closed but at 
> least some of your work could be committed.

My work (and Detlef's too I think) only needs avifil32 and importing 
that, as Detlef suggested, was the way I was able to test things.

I understand that Alexandre would not accept such a patch though. 
Otherwise I would say Detlef's patch should be submitted with this 
import so that my patches can be committed on top of that.

I think it was also stupid of me to send all the patches as a serie, 
while they do not actually depend on each other. I'm not sure though how 
I would submit the patches next time. Should I send the tests depending 
on each other in a separate serie from the actual fixes or is the right 
way actually to send a fix with it's test in the same serie?


More information about the wine-devel mailing list