avifil32: Overwrite dwRate in the audiostream with the nBlockAlign from the wave header
jjmckenzie51 at earthlink.net
Sun Jan 10 16:28:28 CST 2010
Julius Schwartzenberg wrote:
> Paul Vriens wrote:
>> Do any of these patches fix any of the tests? If so you should also
>> change the tests by removing one or more todo_wine()'s.
>> This could become tricky though if your tests patches are not
>> committed before these ones.
> Yes, all the tests work properly with my patches. I had understood
> that todo_wine should be based on the state of current GIT. But I
> understand now that normally a fix should remove an existing todo_wine
> in GIT.
> Right now I'm indeed not sure how to deal with this since I don't know
> whether either the tests and/or the fixes will be committed.
> I kinda hoped Alexandre had some kind of automated way to removed
> fixed todo_wines...
Nope. AJ does not have an automatic 'todo wine' removal tool. However,
you can submit patches as a series, the first patch implements the
function, the second removes the todo wine. If the first patch is
rejected, then the second one is automatically removed. Again, if the
second patch is not changed and you do change the first, you can
'resubmit' the second patch as is with the changed first patch.
More information about the wine-devel