oleaut32: do not crash in logging if string is NULL

Alexandre Julliard julliard at winehq.org
Wed Jan 20 09:51:59 CST 2010


Aric Stewart <aric at codeweavers.com> writes:

> Meaning the place where I am finding this is different bug?
>
> In deserialize_param in the VT_BSTR case if the byte_length of the
> BSTR that we are deserializing is -1  then BSTR_UserUnmarshal places
> NULL into *arg.
>
> I will admit I know very little about this code but having it crash
> when trying to log seemed very wrong.
>
> Should I change the
> if (debugout) TRACE_(olerelay)("%s",relaystr(*(BSTR *)arg));
> to a simple debugstr_w or is this revealing a deeper problem somewhere?

It's an arbitrary string so yes, it should be using debugstr_w.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list