[PATCH 1/2] d3dx9: Fix indentation in D3DXDeclaratorFromFVFTest. (try 4)

James McKenzie jjmckenzie51 at earthlink.net
Wed Jul 7 22:41:45 CDT 2010

Misha Koshelev wrote:
>> Misha Koshelev <misha680 at gmail.com> wrote:
>>> Ok per Dan's comments back to <last as this looks nicer.
>> Misha:
>> Alexandre rejects 'white space' changes, that is changes that fix indentation, remove extraneous or trailing spaces and tabs unless there is another change needed.  If there is a needed change in this file, go ahead and fixup white space around the change.  Otherwise, hold onto this change in case you need to use it in the future.
>> Your other change was accepted by Alexandre and was committed.
>> James McKenzie
> Thanks James and I appreciate the style advice.
> Hope I didn't start anything too bitter about coding styles ;)
> Remember we're all on the same page - making a great product even greater! (Ok enough silly cheery attitude now).
My point is that we should use the same coding style and that should use 
best practices for coding. Yes, I don't know it all and yes I get my 
hand slapped, but I am trying to improve things as well.

Yes, progress is being made on several of the programs that I want to 
incorporate into Wine.  And yes, I will go over the code for best 
practices as well.  Some of the code I built was from others and some 
was just quickly written and is sloppy.  Clean code is maintainable, 
sloppy code is not.

The idea is to keep on moving in a linear direction, forward.  We are 
chasing a big monster, the Windows 32 and Windows 64 APIs and I would 
like to think that we are making great strides forward.

If you have language skills as well as coding skills, you might want to 
look at our translations page and see if you can start/assist with our 
translation effort as well.  Lots to do here.

James McKenzie

More information about the wine-devel mailing list