wined3d: Add NVDB support

Henri Verbeet hverbeet at gmail.com
Mon Sep 13 05:36:58 CDT 2010


2010/9/12 Ričardas Barkauskas <miegalius at gmail.com>:
>
Looks reasonable in general, though there are a few minor issues:

> +        /* Depth bound test. To query if the card supports instancing CheckDeviceFormat with the special
Instancing doesn't have anything to do with this.

> +    union {
> +            DWORD d;
> +            float f;
> +    } zmin, zmax;
Four space indent is enough. You do this in the test patch as well.

> +    if(stateblock->renderState[WINED3DRS_ENABLEADAPTIVETESSELLATION])
> +        FIXME("(WINED3DRS_ENABLEADAPTIVETESSELLATION,%d) not yet implemented\n", stateblock->renderState[WINED3DRS_ENABLEADAPTIVETESSELLATION]);
Note that you can just call state_tessellation() here.

> { STATE_RENDER(WINED3DRS_ADAPTIVETESS_W),             { STATE_RENDER(WINED3DRS_ENABLEADAPTIVETESSELLATION), NULL                }, WINED3D_GL_EXT_NONE             },
>  +    { STATE_RENDER(WINED3DRS_ENABLEADAPTIVETESSELLATION), { STATE_RENDER(WINED3DRS_ENABLEADAPTIVETESSELLATION), state_tessellnvdb   }, EXT_DEPTH_BOUNDS_TEST             },
You have two extra spaces here.



More information about the wine-devel mailing list