Unused code patch in: "mshtml: Added nsIURL::GetQuery implementation."
Jacek Caban
jacek at codeweavers.com
Sat Sep 18 15:16:43 CDT 2010
On 9/18/10 10:04 PM, Joris Huizer wrote:
> Hello,
>
> I found a bit of unused code was introduced in commit ffe9cc87c0e759dffe2a19a96a1e5c7746c7ad62 "mshtml: Added nsIURL::GetQuery implementation."
>
> + ptr_end = url.lpszExtraInfo+url.dwExtraInfoLength;
> + for(ptr = url.lpszExtraInfo; ptr< ptr_end; ptr++) {
> + if(*ptr == '#')
> + break;
> + }
> +
> + ptr = url.lpszExtraInfo;
>
> Either the loop is leftover code, or the last (unconditional) assignment is wrong.
if statement in the loop was supposed to set ptr_end. Thanks for pointing
it out, I've sent a fix.
Jacek
More information about the wine-devel
mailing list