Unused code patch in: "mshtml: Added nsIURL::GetQuery implementation."

Joris Huizer joris_huizer at yahoo.com
Sat Sep 18 15:04:23 CDT 2010


Hello,

I found a bit of unused code was introduced in commit ffe9cc87c0e759dffe2a19a96a1e5c7746c7ad62 "mshtml: Added nsIURL::GetQuery implementation."

+    ptr_end = url.lpszExtraInfo+url.dwExtraInfoLength;
+    for(ptr = url.lpszExtraInfo; ptr < ptr_end; ptr++) {
+        if(*ptr == '#')
+            break;
+    }
+
+    ptr = url.lpszExtraInfo;

Either the loop is leftover code, or the last (unconditional) assignment is wrong.

HTH,
Joris


      



More information about the wine-devel mailing list