[PATCH] dinput: Mark internal symbols as hidden

Marcus Meissner marcus at jet.franken.de
Sat Apr 30 05:31:28 CDT 2011


On Sat, Apr 30, 2011 at 05:18:03AM +0200, Henri Verbeet wrote:
> On 30 April 2011 00:41, Stefan Dösinger <stefandoesinger at gmx.at> wrote:
> > I don't know how much the effect of marking a few functions hidden changes that
> > though. In the d3d code most things are already either static or hidden, and
> > still not using -fPIC on wined3d alone improves things.
> >
> Things like TRACEs still cause pc loads. There's the actual
> wine_dbg_log() call that has to go through the plt, but also the
> string references and the debug channel info that go through the got.
> I suppose that if you're crazy enough about performance to care about
> that kind of thing you'd already compiled those out anyway though.

This is one of our major overheads, yes. 

As distribution packager I wonder if I should build without debug or not.
A special package (wine-nodebug)?
Or just leave out TRACE() messages?

Ciao, Marcus



More information about the wine-devel mailing list