[PATCH 01/10] cmd: Use CSTR_* instead of hardcoded values as result of CompareStringW

Dan Kegel dank at kegel.com
Fri Aug 19 14:08:08 CDT 2011

2011/8/19 Frédéric Delanoy <frederic.delanoy at gmail.com>:
>> Incidentally, that 'Syntax error' probably should go to stderr;
>> and since the cmd tests ignore stderr, that might fix your failure.
> They should eventually go to stderr, but I wouldn't change them right now.
> The current tests can run successfully only if the # lines match in
> the output / expected files, so putting them to stderr instead might/will break
> things.

Do our tests pass on windows cmd?  That outputs errors to stderr, I think.

> I don't know how your code works, and it's probably done already, but
> in certain cases if tests fail, some test files/dirs can be left in
> the test directory, so a preliminary cleanup is probably a wise idea.

The buildbot always does clean builds/tests.
- Dan

More information about the wine-devel mailing list