Try to Implement my first Stub function - AbortPrinter() - (try 2).

Andrew Eikum aeikum at
Tue Feb 8 11:13:19 CST 2011

On 02/08/2011 10:48 AM, Loïc Maury wrote:
>>  First of all set your tab size to 8, and ask your editor to not use tabs
>>  at all.
> I have modified my editor, but I don't know if it 's correct now ?

The indentation looks fine to me now. You've got an extra newline after 
the "if(printer->doc)" block and before the "else." The formatting on 
the TRACE statement is still bizarre. Fix the commas and put it on just 
a couple of lines. No reason for one line and a ton of whitespace for 
each parameter. See line 1944 for an example.

Otherwise, two little things I noticed.

First, you must also check the return value for HeapAlloc().

Second, you should be using the LIST_FOR_EACH_ENTRY_SAFE macro, which 
will eliminate the local cursor and cursor2 variables and make the code 
a little more simple. (Unless there's something I'm missing?)

Almost done, nice work :)


More information about the wine-devel mailing list