avifil32: Skip tests when we couldn't create or open the AVI file
ale.goujon at gmail.com
Thu Feb 10 23:55:53 CST 2011
On 02/11/2011 12:10 AM, Julius Schwartzenberg wrote:
> Is there a specific situation in which the file creation fails? I
> expected the temporary directory would always be writable when I
> created it like that. Maybe that is not a good assumption when writing
> tests though?
I wrote the patch because of the crash seen here :
However, I contacted the user who submitted it and it was in fact a
"stripped" version of Windows.
Nevertheless, I do think the case could happen again (not enough disk
space for instance).
Moreover, it's basically a "if" "win_skip" and "return" so it won't slow
down the test.
What do you think ?
Does it worth applying my patch ?
Well, it's up to you; you know my point of view.
More information about the wine-devel