msvcrt: Partially implement _set_abort_behavior

Nikolay Sivov nsivov at codeweavers.com
Wed Jan 12 10:32:13 CST 2011


On 1/12/2011 07:56, Detlef Riekenberg wrote:
> On Mi, 2011-01-12 at 00:48 +0300, Nikolay Sivov wrote:
>
>> Date: Wed, 12 Jan 2011 00:46:26 +0300
>> Subject: [PATCH 1/1] Partially implement _set_abort_behavior
> Please search the patches queue first.
> try 2: http://source.winehq.org/patches/data/70231
> try 1: http://source.winehq.org/patches/data/70136
Oh, I missed that. Why it's still not committed?
>
>> +static int MSVCRT_abort_behavior =  MSVCRT__WRITE_ABORT_MSG |
>> MSVCRT__WRITE_CALL_REPORTFAULT;
> - _set_abort_behavior get unsigned int, but you use an int. Why?
No particular reason, I don't have up-to-date msvcrt headers to check 
that. So I'm wrong probably and it should be unsigned.
> - mingw header have the same name as msdn.
>    Why are you using different names?
Different name for flag names? Because I thought we don't want to 
include our own stdlib.h but only a system one, am I wrong?

msvcrt.h tells me:

---
  *   Other conventions
  *      - To avoid conflicts with the standard C library,
  *        no msvcrt headers are included in the implementation.
  *      - Instead, symbols are duplicated here, prefixed with
  *        MSVCRT_, as explained above.
---

Probably I got it wrong and I don't need to prefix these symbols because 
there's no equivalent in libc (or there is?). But I'm not sure you mean 
that, right?







More information about the wine-devel mailing list