[PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.

Jacek Caban jacek at codeweavers.com
Tue Jan 18 04:08:19 CST 2011

On 1/17/11 9:28 PM, Erich Hoover wrote:
> On Sun, Jan 16, 2011 at 1:01 PM, Jacek Caban<jacek at codeweavers.com>  wrote:
>> Please write a test case for this. MSDN seems wrong in this case. It indicates in one place that we should use CGID_MSHTML as group GUID, and NULL in the other. The test should make it clean, which version is true.
> I've looked into trying to do this test case and I'm at a bit of a
> loss.  It appears that whatever I try to do the "webbrowser" tests
> hijack the IOleCommandTarget, so I'm not really testing what the
> "real" target does.  It instead calls the test-specific
> OleCommandTarget_QueryStatus, though that test does not report any
> error on the ever-so-significant line:
> ok(!pguidCmdGroup, "pguidCmdGroup != MULL\n");

I'm not sure what you mean by "hijack the IOleCommandTarget". All we do 
is implementing client's IOleCommandTarget. It's something different 
from document's one.

> On a side note, do I need to resend the other two patches in that set?
>   They are not dependent on this patch.

Probably yes.


More information about the wine-devel mailing list