[PATCH] winmm: Don't mask out SND_ALIAS_ID or SND_FILENAME in sndPlaySound
aeikum at codeweavers.com
Wed Dec 5 08:28:41 CST 2012
On Wed, Dec 05, 2012 at 11:21:39PM +0800, Dmitry Timoshkov wrote:
> Andrew Eikum <aeikum at codeweavers.com> wrote:
> > The call is only supposed to return TRUE or FALSE, so I guess it's
> > checking that the return value isn't 3 or something. Not very useful,
> > sure, but it looked odd to just have a series of sndPlaySound calls in
> > a row without ok() calls. The real test is to make sure sndPlaySound
> > doesn't crash, as it does without my patch.
> Then the test is completely useless, it actually tests nothing.
The ok calls are useless, I guess, but they're not doing any harm,
either. You can send a patch to remove the ok calls if you like.
More information about the wine-devel