[PATCH 2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.

Dmitry Timoshkov dmitry at baikal.ru
Fri Jun 1 08:58:56 CDT 2012

Alexandre Julliard <julliard at winehq.org> wrote:

> > What I have done is a comparison of screenshots of the affected application
> > produced under Windows and Wine. If there will be a need in futher improvements
> > I'll certainly have a look what can be enhanced.
> Once again, have you explicitly tested 32-pixel wide characters?
> Obviously other sizes won't show the problem.

No, I haven't specifically tested that case. I believe that I would have
noticed a problem with the application I tested with.

> >> > Besides,
> >> > status of the patches was New, both for the test and this implementation.
> >> 
> >> What has this got to do with anything? If your patch receives comments
> >> you have to address them, I'm not going to review it if someone else
> >> already did.
> >
> > Shouldn't the patch status reflect that? Or commenting on a patch automatically
> > makes it rejected?
> It may or may not, depending on how you address the comments. Usually it
> would become superseded once you send a fixed version.

This clearly shows a lack of communication, which leads to dropping useful
patches. Huw asked a question, I answered in belief that my response makes
things clearer. Satus of the patch remained as 'New', which means "Patch not
even looked at yet", 30 days have passed, the patch disappeared from the patch


More information about the wine-devel mailing list