[PATCH 1/5] d3dx9_36: Implement D3DXFileCreate.
kgbricola at web.de
Mon Oct 22 16:02:24 CDT 2012
On 22.10.2012 22:55, Jacek Caban wrote:
> On 10/22/12 10:13 PM, Rico Schüller wrote:
>> On 22.10.2012 21:27, Christian Costa wrote:
>>> +static HRESULT WINAPI ID3DXFileImpl_QueryInterface(ID3DXFile *iface,
> REFIID riid, LPVOID *ret_iface)
>>> + ID3DXFileImpl *This = impl_from_ID3DXFile(iface);
>>> + ID3DXFileImpl* object;
>> Please be a bit more consistent across your patch... There are a lot
> more occurrences where you mix both usages.
> His usage seems natural when you think about using 'This' as analogy to
> 'this' in C++ implementation. That said, it's really a matter of taste,
> but such analogy feels natural when you work with COM. And by that logic,
> the patch is consistent. It uses 'object' as name of global function,
> which is not member of any class-like thing.
I meant: ID3DXFileImpl* object; vs ID3DXFileImpl *object;
More information about the wine-devel