[PATCH 1/5] d3dx9_36: Implement D3DXFileCreate. (try 3)

[Christian Costa]

Le 24/10/2012 17:53, Dmitry Timoshkov a écrit :
> Christian Costa <titan.costa at gmail.com> wrote:
>
>> Well, that would have been better to spot this *much* earlier.
>>
>> More generally about coding style or rules, that would be *much* better to
>> write a wiki page about this and point to it
>> along with code style comments. I don't mind following rules or adopt "nice
>> to do" but I cannot guess the difference
>> between formal rules, informal ones and personal tastes. It would be better
>> for everyone and focus the review
>> on technical stuff. And this is not the first time I talk about such a page.
> Handling out of memory errors, avoiding useless spam to the console, avoiding
> blanket memset() calls are not the coding style things and they are not specific
> to Wine or any other project, this is basic things a programmers needs to follow
> in general IMHO.
>
I said "more generally". It doesn't apply particularly to this but usual 
comments
we have on the list : indentation, tabs, LPxxx, Microsoft variable 
naming, COM, debugstr_a,
sizeof, ...
I proposed to do such a page but people need to agree on the principle 
and reviewers to use
it to point to it along with comments. This way reviewers can more 
concentrate on technical
stuff. This also help people cleanup the code when there are sending patch.

If I agree with out of memory error, regarding the memset it is 
particular to COM and the incremental
nature of Wine.
In addition not all people are good programmers nor usual Wine 
developper? Note that for some goto is
evil and should never used.
If we have some tips or rules based on Wine code practical experience 
that would help patch submission.