d3dx9_36: Implement D3DXSHRotate

Rico Schüller kgbricola at web.de
Sun Sep 2 16:17:18 CDT 2012


On 02.09.2012 22:28, Nozomi Kodama wrote:
>
> +        for (order = 0; order < 10; order++)
>
Is there a reason why we'd want to test til 9? D3DXSH_MAXORDER is 6, so 
7 Should be enough? I know the other test do this, but technically I see 
no reason for that. Specifically the if (.. order > D3DXSH_MAXORDER) 
says exactly that, so no need to further than 7, since the parameters or 
did I miss something?

I guess you'd also out of bounds?
table[36 * j + i]; (for j=3 and i=99 => 207) since the table only has 
4*36 => 144 elements.

Cheers
Rico



More information about the wine-devel mailing list