[PATCH 1/2] wined3d: Use the np2_fixup to find out if a RECT texture is used

Stefan Dösinger stefandoesinger at gmail.com
Fri Apr 12 02:52:07 CDT 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2013-04-11 13:40, schrieb Henri Verbeet:
> The basic idea is ok, but the conditions for when np2_fixup is set
> are a bit more complicated than that. Specifically, look at how
> the WINED3D_TEXTURE_POW2_MAT_IDENT texture flag is set / cleared
> in texture_init().
I think this should be 'fixed' by supporting conditional NP2 textures
only when texture_rectangle is supported and get rid of other
situations where we scale coordinates.

- -> Fake NP2 cube textures: I don't see how this can possibly work.
We're merely length-scaling a directional vector.

- -> GPUs that don't support ARB_texture_rectangle: Unfortunately I
don't have one of those, but not advertising NP2_CONDITIONAL on those
should be legitimate.

- -> Fallback for P8 textures and EXT_paletted_textures: Problematic
because I can't test this. Not sure if the code even works...

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRZ70nAAoJEN0/YqbEcdMww1MQAIYlL31TtEyZ0z60Ki4KfX4w
bGeaFbfMJPEcgOVzCHxEStmUaHOJFsJufdeEvw16Fs0ZoRHh45O5hRaNaEGCEE7i
bFu5j1eBRXqHmYOrgwoJ328SG/wLAUy2DHyt6EeiebBKsrhvyUnzVDi6qocvie5V
6KNN9y+PB8PE6yipR4Qtts+GBP8jOYvMc38l6S2q9Bq2jNv6fPwXtYsIlQ2Ltl8a
RCsQMSVJashOsBsne6VOJ124DbCT9KzIIwy0/lKMwqxoN+Jvj+Xo9jO4XPEZNUOp
7AsbKl+ssp4JyTjjvxVu4QXXK3EzrpxmCverUxkNG1MS5RUAivKkn+gpCjRVM84w
e2BUy6F5blmig64JuvIb77b7DI5DT3aZlsenGkYkBaITE71szjjssiWlTAbLHf7/
hGIrXklXvf3xL2g+0dCg10lvHA8/1ty5iwG/O1ZH51o5zBCBUHg5+GYNBx66mRgZ
oMXHds3QYU6XIp5S79TmIQPXRBlK553O/N0pwicq98uFh025qjC8GIEkflAqJaKk
CSuAA7diizPLYLWUX4XdAcnDx8H3Xp+JS4SpqsaL61+mOD1gqgnDd5Hx5GgwvqV4
EM0riZq3TeoRjfCzBmn39PSvRIajdVU0Civ9JOj/raKKfQqzIG7KiSYG6T8n9Vl8
7XUAIf0TzEYEbO5P5XF9
=c0yJ
-----END PGP SIGNATURE-----



More information about the wine-devel mailing list