[1/4] windowscodecs: Implement IWICColorContext::InitializeFromFilename.

Hans Leidekker hans at codeweavers.com
Wed Feb 6 12:05:34 CST 2013


On Wed, 2013-02-06 at 18:10 +0100, Ludger Sprenker wrote:
> On Wed, 06 Feb 2013 13:51:32 +0100, Hans Leidekker wrote:
> 
> > + handle = CreateFileW(filename, GENERIC_READ, 0, NULL,
> 
> > OPEN_EXISTING, 0, NULL);
> 
> > + if (handle == INVALID_HANDLE_VALUE) return
> 
> > HRESULT_FROM_WIN32(GetLastError()); 
> 
> I think, you are hiding a fixme for the default color profiles shipped with windows.
> 
> (like "c:\windows\system32\spool\drivers\color\sRGB Color Space Profile.icm")

I don't think this is the right place for such a fixme, it could just as well
be loading a profile that comes bundled with the app. Also note that any attempt
to use the color context will cause a fixme to be printed.





More information about the wine-devel mailing list