Truncate MIDI SysEx messages after termination byte

[Christian Costa]

2013/1/9 Johannes Kroll <jkroll at lavabit.com>

> On Wed, 9 Jan 2013 16:10:18 +0100
> Christian Costa <titan.costa at gmail.com> wrote:
>
> > 2013/1/9 Johannes Kroll <jkroll at lavabit.com>
> >
> > > On Wed, 09 Jan 2013 10:19:54 +0100
> > > Christian Costa <titan.costa at gmail.com> wrote:
> > >
> > > > Le 09/01/2013 04:26, Johannes Kroll a écrit :
> > > > > Hi,
> > > > >
> > > > > On Wed, 09 Jan 2013 03:55:25 +0100
> > > > > Christian Costa <titan.costa at gmail.com> wrote:
> > > > >
> > > > >> Hi,
> > > > >>
> > > > >> Please be consistent when using space. 1 space before and after
> > > > >> operators (<, ==, =, ...).
> > > > > spaces inserted. HTH.
> > > > >
> > > > > J.
> > > > That's better. You forgot some occurences in the for loop though.
> > >
> > > Is it OK if I leave the rest of the formatting to you? Any style is
> > > fine with me, whatever makes you happy and hopefully gets the patch
> > > included.
> > >
> > > Formatting only patch are not allowed. Clean patch and consistency in
> code
> > style help your patch get in.
> > Alexandre Julliard is the only judge not me. If he is ok with your patch
> > that's fine.
> > Anyway having the for loop consistent with rest should not be that hard.
> >
> > for(i= 0; i<lpMidiOutHdr->dwBufferLength; i++)
>
> The original patch was consistent with my coding style. To make
> assignments stick out visually, I use no space to the left of the
> assignment operator, one space to the right. On comparison operators, I
> use space either on both sides, or none. You will see this in all code
> I write.
>
> I attached another version of the patch. I added 3 more spaces and one
> line break in a long comment line. You or Alexandre can choose the
> version they like best. If you still see style issues, please consider
> changing the style to your liking. If that's not possible, the patch
> will have to be rejected.
>
>
I would say consistency would be 2 spaces or none.
Using only 1 space for assignment does not seem very common in wine AFAIK.
In general it's better to follow the file style or the function to avoid
mixing styles
except if you work heavyly on these files.



> If anybody sees non-style-related issues with the patch, please let me
> know.
>

dwBytesRecorded is supposed to tell how many bytes are valid. What's wrong
with it ?


>
> Please keep any replies on the list(s).
>
>
Good mail client which sucks.
wine-patches is only for patch submission.


> Have a nice day.
> Johannes
>
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20130109/048489d4/attachment.html>