[PATCH] windowscodecs/tests: Fix a test failure [newwtb and other]
Dmitry Timoshkov
dmitry at baikal.ru
Fri Jul 5 05:43:47 CDT 2013
Detlef Riekenberg <wine.dev at web.de> wrote:
> - /* global palette */
> + /* global palette. This succeed since win7sp1 with platform update / win8 */
This comment is not helpful.
> hr = IWICBitmapDecoder_CopyPalette(decoder, palette);
> - ok(hr == WINCODEC_ERR_FRAMEMISSING,
> - "expected WINCODEC_ERR_FRAMEMISSING, got %#x\n", hr);
> + ok((hr == S_OK) || (hr == WINCODEC_ERR_FRAMEMISSING),
> + "expected S_OK or WINCODEC_ERR_FRAMEMISSING, got %#x\n", hr);
One of test results should be marked as broken, and in the S_OK case
the resulting palette should be tested and released. I'd guess that newer
version should be taken as a model to follow, and Wine implementation
should be fixed appropriately.
--
Dmitry.
More information about the wine-devel
mailing list