[PATCH 5/5] kernel32/tests: remove several todos in test_waittxempty

Dmitry Timoshkov dmitry at baikal.ru
Thu Sep 5 04:53:53 CDT 2013


Wolfgang Walter <wine at stwm.de> wrote:

> > > > WaitCommEvent always returns FALSE when device is opened in overlapped
> > > > mode.> 
> > > Not according to MSN documentation of WaitCommEvent():
> > > 
> > > "If the overlapped operation cannot be completed immediately, the function
> > > returns FALSE and the GetLastError function returns ERROR_IO_PENDING,
> > > indicating that the operation is executing in the background."
> > 
> > We have the tests for that, MSDN descriptions are proved to be often
> > incorrect or incomplete.
> 
> Then you think that wine behaviour should be changed?

If the test result is marked as todo_wine then yes.

> If yes I'll send a 
> patch. But I wonder as wine does quit some effort to do otherwise.

I'm already working on fixing bugs discovered by kernel32 comm and related
ntdll file tests.

-- 
Dmitry.



More information about the wine-devel mailing list