[PATCH 5/8] wined3d: Implement locking of block-based volume textures.

Stefan Dösinger stefan at codeweavers.com
Tue Sep 17 07:58:10 CDT 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2013-09-17 13:55, schrieb Henri Verbeet:
> On 17 September 2013 11:39, Stefan Dösinger
> <stefan at codeweavers.com> wrote:
>> --- dlls/wined3d/volume.c | 95
>> +++++++++++++++++++++++++++++++++++++++++++++++---- 1 file
>> changed, 88 insertions(+), 7 deletions(-)
>> 
> Can't most of this be done on the resource level instead?
Yes, but I'd prefer to migrate surfaces and buffers to the new
location flags and clean up VBO/PBO handling before merging the map
implementations. I also think it's better to have the tests in place
without lots of todos before such a restructuring.

Error checking is a fairly minor detail in this in my opinion. The
more interesting part is MAP_DISCARD handling, especially with regard
to the command stream.

I have the surface cleanup partially done, buffers are still on the
todo list.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSOFHiAAoJEN0/YqbEcdMw72EP/iEWJ0WE2Ayrm4mMsXZ6uNsi
brxk0en0ltGfS5AonYefFfsHsdxRwvP/J+ybbR8fx4/vBtGpN40bGECk1kV1iyBp
WjdfC4RINVh/blHl+DFjKEGfHhb2uodxIFiClEzd5QNRLVzZzJdfh1+DGEZWtcdy
Kkkd3xwzYS9LJFRsIJ4UhG3JP/0N+2Vvqt8NnOq0ZCXFcurnmgKAzg7qYvsPaT7r
2bhLz6QXHXOCR9W8ZDMGJM58xYesJ02ctQTpj0xxQdq5bfhmRXcRjqv1vikHKq7+
sPUrtOdH+/FsliM0qY8LUIb4jbG5SDCEx1ZIvcmQR0MftgYHoTY36LOQy5n4L0lk
ChMsAGIZlJMW0So/L88yyE0pyFnbYp5xK7oVA4WazxtTIIb89OhlqtERc31pYD//
6PVpzaGe4+z7c+qXRF/TiYSVJwD/Ff//n2UdR9mbQiJmkUYjFIXsQNoD8Ep1j6fw
J8oXvWgUDQRre3asoxNFadpNYBrHxb4+xypaIfCitKoJDJ6lOYvUiKSSZOOITAd1
yOCWJUy37HqCvKt4h7S9HhXFTNY2Gx7JBnMWRdABBjw+VuFHVNK09hJdcAFcX2ZK
ry0TYXFebTkIlBVXXjUFpDczg+dgYmqWOOPSC3xZac+9BMR5H8ERr3dUMyT73DnR
7qowSJjPsi330yrIOPSu
=BfCu
-----END PGP SIGNATURE-----



More information about the wine-devel mailing list