[PATCH 5/8] wined3d: Implement locking of block-based volume textures.
hverbeet at gmail.com
Tue Sep 17 08:05:49 CDT 2013
On 17 September 2013 14:58, Stefan Dösinger <stefan at codeweavers.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> Am 2013-09-17 13:55, schrieb Henri Verbeet:
>> On 17 September 2013 11:39, Stefan Dösinger
>> <stefan at codeweavers.com> wrote:
>>> --- dlls/wined3d/volume.c | 95
>>> +++++++++++++++++++++++++++++++++++++++++++++++---- 1 file
>>> changed, 88 insertions(+), 7 deletions(-)
>> Can't most of this be done on the resource level instead?
> Yes, but I'd prefer to migrate surfaces and buffers to the new
> location flags and clean up VBO/PBO handling before merging the map
> implementations. I also think it's better to have the tests in place
> without lots of todos before such a restructuring.
I was mostly thinking of merging e.g. wined3d_surface_get_pitch() and
wined3d_volume_get_pitch() into wined3d_resource_get_pitch(). I don't
feel strongly about doing that first though, so if you're saying
you'll get to that eventually that's ok.
More information about the wine-devel