[PATCH 2/4] d3d9/tests: Test that Direct3D9 doesn't modify the pixel format of the window it targets. (try 4)

[Ken Thomases]

On Feb 19, 2014, at 12:25 PM, Ken Thomases wrote:

> On Feb 19, 2014, at 4:36 AM, Henri Verbeet wrote:
> 
>> I think
>> there's also an argument somewhere that context_update_window() should
>> set needs_set instead of calling context_set_pixel_format() and
>> context_set_gl_context().

Hmm.  The one issue is that, if the context_set_pixel_format() in context_update_window() fails, the context is marked as invalid and left that way.  If we simply set needs_set instead, then context_acquire() will call context_set_gl_context().  That will try context_set_pixel_format() again but this time, if it fails, it will try the swapchain backup DC.  I don't really know if that's desired.  I assume the code is structured the way it is for a reason (i.e. a call to context_set_pixel_format() immediately before a call to context_set_gl_context(), which already begins with a call to the former).

-Ken