[PATCH 2/4] d3d9/tests: Test that Direct3D9 doesn't modify the pixel format of the window it targets. (try 4)

[Henri Verbeet]

On 19 February 2014 20:06, Ken Thomases <ken at codeweavers.com> wrote:
> Hmm.  The one issue is that, if the context_set_pixel_format() in context_update_window() fails, the context is marked as invalid and left that way.  If we simply set needs_set instead, then context_acquire() will call context_set_gl_context().  That will try context_set_pixel_format() again but this time, if it fails, it will try the swapchain backup DC.  I don't really know if that's desired.  I assume the code is structured the way it is for a reason (i.e. a call to context_set_pixel_format() immediately before a call to context_set_gl_context(), which already begins with a call to the former).
>
Trying the backup DC would be correct. I probably just forgot to get
rid of the context_set_pixel_format() call in context_update_window()
back when I made context_restore_gl_context() try to restore the pixel
format as well. The backup DC code was added even later by Matteo.