[PATCH 3/4] mshtml: Add IHTMLSelectElement::name property implementation.
Jacek Caban
jacek at codeweavers.com
Fri Aug 7 11:03:37 CDT 2015
On 08/07/15 12:12, Zhenbo Li wrote:
> - if(NS_SUCCEEDED(nsres)) {
> - static const WCHAR wszGarbage[] = {'g','a','r','b','a','g','e',0};
>
> - nsAString_GetData(&name_str, &name);
> + nsAString_GetData(&name_str, &name);
> + if(*name)
> + *p = SysAllocString(name);
> + else
> + *p = NULL;
> + nsAString_Finish(&name_str);
>
> - /*
> - * Native never returns empty string here. If an element has no name,
> - * name of previous element or ramdom data is returned.
> - */
> - *p = SysAllocString(*name ? name : wszGarbage);
> - }else {
> + if(NS_FAILED(nsres)) {
> ERR("GetName failed: %08x\n", nsres);
> + return E_FAIL;
> }
> -
> - nsAString_Finish(&name_str);
> -
> - TRACE("name=%s\n", debugstr_w(*p));
> return S_OK;
Why don't you use return_nsstr?
Jacek
More information about the wine-devel
mailing list