user32: Set correct caret state in the server in SetCaretPos (try 2)
Sebastian Lackner
sebastian at fds-team.de
Mon Dec 21 14:32:54 CST 2015
On 20.12.2015 19:42, Anton Baskanov wrote:
> Signed-off-by: Anton Baskanov <baskanov at gmail.com>
>
> The code in SetCaretPos doesn't change the caret state if it's position is unchanged.
> Reflect this at the server side to avoid caret corruption.
>
> try2:
> - fixed incorrect if statement in the server
> ---
> dlls/user32/caret.c | 2 +-
> server/protocol.def | 3 ++-
> server/queue.c | 5 +++++
> 3 files changed, 8 insertions(+), 2 deletions(-)
After playing around a bit more I can confirm that this is the right way to fix it.
I was already about to send my sign-off, but then I noticed that it breaks
./tools/make_requests, which doesn't seem to like multiline comments in protocol.def.
$ ./tools/make_requests
Unrecognized syntax * -2=on if the position differs, unchanged otherwise) */ at ./tools/make_requests line 257, <PROTOCOL> line 2981.
Please resend after fixing this issue (probably just make the comment a bit smaller),
then I'll add my signoff. ;)
Best regards,
Sebastian
More information about the wine-devel
mailing list