d3dx9_36: add D3DXDisassembleShader stub (try 2)

Dmitry Timoshkov dmitry at baikal.ru
Thu Feb 5 02:56:46 CST 2015


Stefan Dösinger <stefandoesinger at gmail.com> wrote:

> Am 2015-02-05 um 05:14 schrieb Austin English:
> > +HRESULT WINAPI D3DXDisassembleShader(const DWORD *shader, BOOL 
> > colorcode, LPCSTR comments, LPD3DXBUFFER *disassembly)
> Please no LPCRAP:
> 
> LPCSTR -> const char *

That's how it's supposed to look like - LPCSTR, not const char *.
This is a public API, not an internal helper.

> LPD3DXBUFFER * -> ID3DXBuffer **
> 
> It is even written this way in our header.

Then the header should be fixed instead:
https://msdn.microsoft.com/ru-ru/library/windows/desktop/bb172820%28v=vs.85%29.aspx

-- 
Dmitry.



More information about the wine-devel mailing list