[PATCH] [shell32] Implement SHRunControlPanel using ShellExecute

Alex Henrie alexhenrie24 at gmail.com
Fri Feb 27 02:49:04 CST 2015


2015-02-26 7:36 GMT-07:00 Nikolay Sivov <bunglehead at gmail.com>:
> On 26.02.2015 17:01, Robert Naumann wrote:
>> -       FIXME("(%s, %p): stub\n", debugstr_w(commandLine), parent);
>> -       return FALSE;
>> +    if((int)ShellExecute(parent,NULL,commandLine,NULL,NULL,SW_NORMAL)>32)
>> +        return TRUE;
>> +    else
>> +        return FALSE;
>
> Why 32? Also please don't remove tracing line.

MSDN says that ShellExecute returns a value of 32 or less if it fails,
and a value greater than 32 if it succeeds:
https://msdn.microsoft.com/en-us/library/windows/desktop/bb762153%28v=vs.85%29.aspx

-Alex



More information about the wine-devel mailing list