[PATCH] [shell32] Implement SHRunControlPanel using ShellExecute

Alex Henrie alexhenrie24 at gmail.com
Fri Feb 27 02:50:02 CST 2015

+    if((int)ShellExecute(parent,NULL,commandLine,NULL,NULL,SW_NORMAL)>32)
+        return TRUE;
+    else
+        return FALSE;

I think this would be more elegantly expressed as

return (int)ShellExecute(parent,NULL,commandLine,NULL,NULL,SW_NORMAL)>32;

But more importantly, are you sure that SHRunControlPanel will execute
anything? What if the filename doesn't end in .cpl? You'll probably
have to write some tests before this patch is accepted.


More information about the wine-devel mailing list