[PATCH 1/2] kernel32/tests: Make loader tests independent from each other

Nikolay Sivov nsivov at codeweavers.com
Wed Jan 28 09:43:16 CST 2015


On 28.01.2015 18:39, Dmitry Timoshkov wrote:
> Nikolay Sivov <nsivov at codeweavers.com> wrote:
>
>>> There are various reasons of the current tests structure, if you are not
>>> planning to add new tests please leave the code as it is please.
>>>
>> Are you going to name those reasons?
> I don't think it's really important unless you are going to add new tests.
That's how I saw they depend on each other, when I tried to add some more.
>
>> Currently some tests depend on
>> values set by previous tests.
>> That's clearly a broken behavior. test_import_resolution() does it right
>> already by the way.
>>
>> So why should I leave it as it is?
> There is no actual reason to touch it, and these purely cosmetic changes
> create conflicts with the tests I have in local tree.
>
Well, local merge problems can't be a reason to block cleanups like that.



More information about the wine-devel mailing list