[PATCH 4/6] propsys: Implement named properties, serialization on the in-memory store

Vincent Povirk madewokherd at gmail.com
Wed Jul 15 13:20:05 CDT 2015

Maybe you know this, but this patch does too many things and will need
to be split before sending to wine-patches.

PropertyStore_SetNamedValue leaks a copy of the value when a new
propstore_named_value can't be allocated.

+    if (!psps && !cb) /* special case: empty storage */

Is it really not enough to have a size of 0? The buffer has to be NULL as well?

+    /* MSDN mandates generic error codes */

MSDN's lists of error codes aren't necessarily exhaustive.

More information about the wine-devel mailing list