[PATCH] advapi32: test and fix ChangeServiceConfig2 when given a zero length or a null description (try2, resend)

Bernhard Übelacker bernhardu at vr-web.de
Fri Jul 17 14:15:37 CDT 2015

Am 17.07.2015 um 15:35 schrieb Marvin:
> Hi,
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> Full results can be found at
> https://testbot.winehq.org/JobDetails.pl?Key=15399
> Your paranoid android.
> === w7u (32 bit service) ===
> service.c:1421: Test failed: Active services mismatch 1
> service.c:1422: Test failed: Inactive services mismatch 4294967295


On two attempts to send a patch modifying the service tests I got a failing
test in the "w7u" VM while the other VMs were succeeding [1][2][3].

This test first gets the number of active and inactive services.
Then enumerates all services and decrements the corresponding counter.
At the end both counter should be zero.

I am now under the impression that this is just a race condition of this
VM when the patch arrives via patchwatcher.
The same patch gave no error when sent via the testbot web interface [4][5].

Is there something against this theory about one service stopping between the
different calls to EnumServicesStatusA?

Would the attached patch be acceptable for inclusion?

It gets the counter before and after enumeration and just
tests if the original values have not changed in between.

Kind regards,

[1] https://testbot.winehq.org/JobDetails.pl?Key=15399
[2] http://source.winehq.org/patches/data/112996.testfail
[3] http://source.winehq.org/patches/data/111835.testfail
[4] https://testbot.winehq.org/JobDetails.pl?Key=15334
[5] https://testbot.winehq.org/JobDetails.pl?Key=15406

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-advapi32-tests-Skip-check-when-service-counter-do-no.patch
Type: text/x-patch
Size: 4721 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20150717/0ab03a6d/attachment.bin>

More information about the wine-devel mailing list