gdiplus: Implement trivial case of GdipCreateRegionRgnData for empty and infinite regions
sebastian at fds-team.de
Tue Jun 9 01:47:28 CDT 2015
On 09.06.2015 08:34, Nikolay Sivov wrote:
> On 09.06.2015 9:24, Dmitry Timoshkov wrote:
>> Nikolay Sivov <nsivov at codeweavers.com> wrote:
>>> First bits for https://bugs.winehq.org/show_bug.cgi?id=34843
>> What is the reason of reimplementing it when wine-staging already
>> includes full implementation with tests?
> The reason is simple, to have this actually implemented in wine. The fact that it's included somewhere doesn't help with that.
> When I asked you yesterday to submit it, that was your response https://bugs.winehq.org/show_bug.cgi?id=34843#c12.
I can only repeat what I already tried to tell you several times on IRC. With your current approach, taking existing patches, rewriting them in your own style, and then submitting them upstream, you are not really helping to solve existing problems with patch acceptance. Are you planning to rewrite all Staging patches, and send them upstream on your own?
If there is nothing wrong with Dmitrys patch you could easily submit it as-is, and give proper attribution. If there is something wrong, you could inform him about the issues you found, so he can improve it. The reason why he doesn't want to resend is most likely that the last few attempts were without any useful comments.
More information about the wine-devel