d3drm patch feedback

Aaryaman Vasishta jem456.vasishta at gmail.com
Thu Jun 18 10:49:16 CDT 2015

On Thu, Jun 18, 2015 at 8:39 PM, Stefan Dösinger <stefandoesinger at gmail.com>

> Hash: SHA1
> Hi,
> Here's the feedback for the patch you posted on IRC:
> > +    GUID driver = IID_IDirect3DRGBDevice;
> Do you need this? Can't you just pass &IID_IDirect3DRGBDevice to
> CreateDeviceFromClipper? It may generate a const warning though.
It does generate the const warning :)

> What if the clipper has no HWND and no clip list?
It will still create the device, though nothing will be shown on the window
which is displayed (just checked on a sample program on windows).

I'll do the rest of the changes and post to wine-patches for final review.

Thank you!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20150618/4afee357/attachment.html>

More information about the wine-devel mailing list