[PATCH] advapi32: succeed for null pointer in ChangeServiceConfig2

Fri Mar 20 06:17:42 CDT 2015

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Good work debugging this. My knowledge about advapi32 is limited, but I
have a comment about the test:

Am 2015-03-19 um 13:06 schrieb Bernhard Übelacker:
> +    pConfig->lpDescription = NULL;
> +    ret = pChangeServiceConfig2A(svc_handle, SERVICE_CONFIG_DESCRIPTION,buffer);
> +    ok(ret, "ChangeServiceConfig2A failed with null pointer\n");
> +    if (!ret) {
> +        goto cleanup;
> +    }
Adding the test like this may work, but I don't think it is the right
way. This call may overwrite settings set by the previous
ChangeServiceConfig2A call if it succeeds. If it fails (and doesn't
crash) the test can continue just fine since the previous call set up
the configuration.

I think it would be better to move this into its own test.