d3drm/tests: Add QueryInterface tests for IDirect3DRMFrame

Aaryaman Vasishta jem456.vasishta at gmail.com
Sun Mar 29 10:46:17 CDT 2015


Actually this patch fails windows tests. That means the return value is not
right at D3DRM and D3DRMDevice, and I'm also getting wrong refcounts for
all IDirect3DRMFrame{1-3} (after putting the correct return values).

I'll also keep the splitting up of files in mind as I write more tests in
the future. :)

On Sun, Mar 29, 2015 at 8:39 PM, Stefan Dösinger <stefandoesinger at gmail.com>
wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am 2015-03-29 um 15:37 schrieb Aaryaman Vasishta:
> > +        { &IID_IDirect3DRM,                NULL,
>  E_NOINTERFACE,       FALSE },
> It's funny that this interface returns the right error value on QI.
>
> > +    hr = IDirect3DRM_CreateFrame(d3drm3, NULL, &frame3);
> Minor nitpick: IDirect3DRM3_CreateFrame . You can resend the patch with a
> fix if you want, but I'm OK with this patch as it is.
>
> Something to think about for future tests: It may make sense to split up
> d3drm.c into d3drm1.c, d3drm2.c and d3drm3.c for each interface version,
> similar to the ddraw tests.
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iQIcBAEBAgAGBQJVGBWOAAoJEN0/YqbEcdMwLkUP/3S8gOP5XSYOgOkELFOSznNp
> ir09O5ef1HUpECpZjCks7ez4IbUhswcb/idJ3UeEx3lSBy4vIk3vY0usXcXKkfMl
> TlioDlOuzKhpXxb/5lZ/SUoG/nguBvzisKeifAA1gi8ne+3REhWeJvY6iBNDNDEX
> dNUYiTP+qxsq8c+bzgydxDuu0OT7LVEXrVrDO1g3qOebJjFSdkXOnf1bCntejX4S
> WdnxPlioWBMvffP42r0oinXzjoqobi5BDw8r4YppflEUou1bH3oT7fczJEpK4rBm
> 2ZDz9EOhvMOa6M5PSiqwPpINfI1PpH+p9S0r3iMZz8ux2VbXDyfJ0i/5CdzQ3HX8
> rnNq/NcObXVgweBYIN7uFvjlo0Si963ACYDperAVyBNgP/oJXsz3dA5ysvrf6Lf8
> Xy1kdP2B79AxWR3DRumQS9sbruaofENF16/7d9MZE933uWY9xBS6JIKTP0AVdDsP
> tqF8ppHwVdPfpiazYnrG1ivpE0jNIPJJ67I6FWRC1S8k7QQVmbAdVnDgczDs6lLx
> hiZbjksd4Uf16oGO29bXeZ2YM3Zi75K9pCa7ruYoftcF2ihd0tU01+jbM6hY32qm
> K1RKe7/HCMANoal7pQEukARHVRvHDpVFRGJzeMbysc8yumnpbgl7/UI9z0wZvoYI
> aCAXfxi21aSdCzxC7mIU
> =9SMA
> -----END PGP SIGNATURE-----
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20150329/11a1436e/attachment.html>


More information about the wine-devel mailing list