[PATCH 1/2] winemac: Use CVDisplayLink to limit window redrawing to the display refresh rate.

[Huw Davies]

On Fri, Nov 06, 2015 at 02:47:10AM -0600, Ken Thomases wrote:
>  dlls/winemac.drv/Makefile.in    |   2 +-
>  dlls/winemac.drv/cocoa_window.h |   2 +
>  dlls/winemac.drv/cocoa_window.m | 166 ++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 169 insertions(+), 1 deletion(-)

Hi Ken,

This doesn't build for me on 10.7:

gcc -m32 -c -o cocoa_window.o cocoa_window.m -I. -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe \
  -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes \
  -Wwrite-strings -Wpointer-arith -gdwarf-2 -fno-omit-frame-pointer -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0
cocoa_window.m:161: error: expected specifier-qualifier-list before ‘CVDisplayLinkRef’
cocoa_window.m:174: error: expected ‘)’ before ‘displayLink’
cocoa_window.m: In function ‘-[WineDisplayLink initWithDisplayID:]’:
cocoa_window.m:181: warning: implicit declaration of function ‘CVDisplayLinkCreateWithCGDisplay’
cocoa_window.m:181: error: ‘_link’ undeclared (first use in this function)
cocoa_window.m:181: error: (Each undeclared identifier is reported only once
cocoa_window.m:181: error: for each function it appears in.)
cocoa_window.m:185: warning: implicit declaration of function ‘CVDisplayLinkSetOutputCallback’
cocoa_window.m:185: error: ‘WineDisplayLinkCallback’ undeclared (first use in this function)
cocoa_window.m: In function ‘-[WineDisplayLink dealloc]’:
cocoa_window.m:200: error: ‘_link’ undeclared (first use in this function)
cocoa_window.m:202: warning: implicit declaration of function ‘CVDisplayLinkStop’
cocoa_window.m:203: warning: implicit declaration of function ‘CVDisplayLinkRelease’
cocoa_window.m: In function ‘-[WineDisplayLink addWindow:]’:
cocoa_window.m:215: warning: implicit declaration of function ‘CVDisplayLinkStart’
cocoa_window.m:215: error: ‘_link’ undeclared (first use in this function)
cocoa_window.m: In function ‘-[WineDisplayLink removeWindow:]’:
cocoa_window.m:225: error: ‘_link’ undeclared (first use in this function)
cocoa_window.m: At top level:
cocoa_window.m:242: error: expected ‘)’ before ‘displayLink’
cocoa_window.m: In function ‘+[WineWindow createWindowWithFeatures:windowFrame:hwnd:queue:]’:
cocoa_window.m:689: error: request for member ‘autodisplay’ in something not a structure or union
cocoa_window.m: In function ‘-[WineWindow orderBelow:orAbove:activate:]’:
cocoa_window.m:1310: warning: ‘WineWindow’ may not respond to ‘-checkWineDisplayLink’
cocoa_window.m:1310: warning: (Messages without a matching method signature
cocoa_window.m:1310: warning: will be assumed to return ‘id’ and accept
cocoa_window.m:1310: warning: ‘...’ as arguments.)
cocoa_window.m:1329: warning: ‘WineWindow’ may not respond to ‘-checkWineDisplayLink’
cocoa_window.m: In function ‘-[WineWindow doOrderOut]’:
cocoa_window.m:1370: warning: ISO C90 forbids mixed declarations and code
cocoa_window.m:1372: warning: ‘WineWindow’ may not respond to ‘-grabDockIconSnapshotFromWindow:force:’
cocoa_window.m:1383: warning: ‘WineWindow’ may not respond to ‘-checkWineDisplayLink’
cocoa_window.m: In function ‘-[WineWindow checkWineDisplayLink]’:
cocoa_window.m:1682: warning: ‘WineWindow’ may not respond to ‘-isEmptyShaped’
cocoa_window.m:1689: warning: ISO C90 forbids mixed declarations and code
cocoa_window.m:1694: warning: ISO C90 forbids mixed declarations and code
cocoa_window.m: In function ‘-[WineWindow grabDockIconSnapshotFromWindow:force:]’:
cocoa_window.m:1744: warning: ISO C90 forbids mixed declarations and code
cocoa_window.m:1761: warning: ISO C90 forbids mixed declarations and code
cocoa_window.m:1774: warning: ISO C90 forbids mixed declarations and code
cocoa_window.m:1781: warning: ISO C90 forbids mixed declarations and code
cocoa_window.m:1785: warning: ISO C90 forbids mixed declarations and code
cocoa_window.m:1788: warning: ISO C90 forbids mixed declarations and code
cocoa_window.m:1805: warning: ‘NSImage’ may not respond to ‘-drawInRect:’
cocoa_window.m:1811: warning: ISO C90 forbids mixed declarations and code
cocoa_window.m: In function ‘-[WineWindow miniaturize:]’:
cocoa_window.m:2031: warning: ISO C90 forbids mixed declarations and code
cocoa_window.m: In function ‘-[WineWindow windowWillResize:toSize:]’:
cocoa_window.m:2413: warning: ISO C90 forbids mixed declarations and code
cocoa_window.m: In function ‘-[WineWindow draggingEntered:]’:
cocoa_window.m:2554: warning: ‘WineWindow’ may not respond to ‘-draggingUpdated:’
cocoa_window.m:2554: warning: return makes integer from pointer without a cast
make[1]: *** [cocoa_window.o] Error 1
make: *** [dlls/winemac.drv] Error 2