[2/2] oleaut32: Implement a better stub for IPicture::SaveAsFile.

Alexandre Julliard julliard at winehq.org
Tue Nov 24 23:14:29 CST 2015

Dmitry Timoshkov <dmitry at baikal.ru> writes:

> Alexandre Julliard <julliard at winehq.org> wrote:
>> >> > Based on OLEPictureImpl_Save implementation.
>> >> 
>> >> Surely you don't need to duplicate all of it.
>> >
>> > Otherwise I would need to rewrite both SaveAsFile() and Save(), which could be
>> > inappropriate for the code freeze, so I decided to just fix SaveAsFile() which
>> > is clearly broken at the moment. It should be possible to reduce the duplication,
>> > but only after 1.8 is released.
>> OK, if you promise to do that after 1.8, I'll put it in ;-)
> It should be pretty easy to make Save() call SaveAsFile() as a backend.

I failed to notice in my test run yesterday, but this is causing test
failures in gdiplus. It's possible that this would have far-reaching
consequences, so I'm going to revert the patch for now. It will have to
be redone properly after code freeze. Sorry about that.

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list