[PATCH 3/3] wined3d: Cleanup extension check for shader model 4 support.

Henri Verbeet hverbeet at gmail.com
Thu Oct 29 06:54:34 CDT 2015


On 28 October 2015 at 22:27, Matteo Bruni <mbruni at codeweavers.com> wrote:
> -    if (gl_info->supported[EXT_GPU_SHADER4] && gl_info->supported[ARB_SHADER_BIT_ENCODING]
> -            && gl_info->supported[ARB_GEOMETRY_SHADER4] && gl_info->glsl_version >= MAKEDWORD_VERSION(1, 50)
> -            && gl_info->supported[ARB_DRAW_ELEMENTS_BASE_VERTEX] && gl_info->supported[ARB_DRAW_INSTANCED]
> -            && gl_info->supported[ARB_TEXTURE_RG] && gl_info->supported[ARB_SAMPLER_OBJECTS])
> +    if (gl_info->glsl_version >= MAKEDWORD_VERSION(1, 50) && gl_info->supported[ARB_SHADER_BIT_ENCODING]
> +            && gl_info->supported[ARB_SAMPLER_OBJECTS])
Dropping EXT_gpu_shader4 is fine. Does GLSL 1.50 imply all the other
extensions you're dropping here? They're not strictly required for
compiling SM4 shaders, but they are for d3d10+ features like e.g.
geometry shaders and instanced draws.



More information about the wine-devel mailing list