[PATCH 3/5] user32: Don't enable owner in DIALOG_DoDialogBox.

Dmitry Timoshkov dmitry at baikal.ru
Wed Apr 6 08:04:08 CDT 2016

Jacek Caban <jacek at codeweavers.com> wrote:

> --- a/dlls/user32/controls.h
> +++ b/dlls/user32/controls.h
> @@ -241,7 +241,6 @@ typedef struct tagDIALOGINFO
>  #define DF_END  0x0001
> -#define DF_OWNERENABLED 0x0002

As I already mentioned during our conversation in wine-devel my (not yet
submitted) tests show that completely removing DF_OWNERENABLED handling
is wrong.

And once again I'd like to see the tests submitted first with todo_wine
statements in appropriate places, and the patches sent only after that
with separate fixes for every failure found by the tests. Sending a bunch
of tests as the final patch doesn't show what didn't actually work before,
and what exactly has been fixed by the patch series.


More information about the wine-devel mailing list