[1/2] shell32: Check IsWow64Process() before calling Wow64 functions.

Alexandre Julliard julliard at winehq.org
Thu Apr 21 02:40:21 CDT 2016

"Olivier F. R. Dierick" <o.dierick at piezo-forte.be> writes:

> I don't know if resetting last error in SHFileOperation() is conformant.
> That's why I took the route to fix one error at a time until there were
> none left. More errors may be introduced later, but for now this patch
> is the last one needed to fix bug 36838.
> I find forcing ERROR_SUCCESS in SHFileOperation() a brute and lazy way
> to fix things. It may hide other errors. Fixing the internal code itself
> may avoid bugs in other functions and is the way to go in my opinion.

If the application depends on this, setting it explicitly is better than
depending on side effects of internal code paths.

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list