[1/2] shell32: Check IsWow64Process() before calling Wow64 functions.

Alexandre Julliard julliard at winehq.org
Thu Apr 21 21:15:38 CDT 2016

"Olivier F. R. Dierick" <o.dierick at piezo-forte.be> writes:

> Ok, the patch does not fix bug 36838. I'll follow your recommandation
> and make another one.
> Still, I found code that generates errors for no purpose on 32 bit wine
> and made a patch to fix it, avoiding possible error leaks and side
> effects. Will it be considered?

In general, errors generated in internal code paths don't matter. If the
function fails in the end, it should set a proper error code. If it
doesn't fail, the error code is irrelevant and isn't supposed to be
checked by the app. In cases where an app mistakenly does check it,
again we have to set it explicitly. Complicating internal code paths to
avoid changing last error is not worth the trouble; in many cases the
same thing happens on Windows anyway.

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list