[PATCH] d3dx9: Fix a typo in TRACE() message.

Matteo Bruni matteo.mystral at gmail.com
Thu Dec 15 16:22:38 CST 2016


2016-12-12 11:21 GMT+01:00 Andrey Gusev <andrey.goosev at gmail.com>:
> @@ -750,7 +750,7 @@ D3DXMATRIX* WINAPI D3DXMatrixTransformation(D3DXMATRIX *pout, const D3DXVECTOR3
>      D3DXQUATERNION prc;
>      D3DXVECTOR3 psc, pt;
>
> -    TRACE("pout %p, pscalingcenter %p, pscalingrotation %p, pscaling %p, protationcentr %p, protation %p, ptranslation %p\n",
> +    TRACE("pout %p, pscalingcenter %p, pscalingrotation %p, pscaling %p, protationcenter %p, protation %p, ptranslation %p\n",
>          pout, pscalingcenter, pscalingrotation, pscaling, protationcenter, protation, ptranslation);
>
>      if ( !pscalingcenter )

It would be nice to clean up the function while at it (add the missing
period at the end of the trace, drop the useless 'p' prefix from all
the parameters and most of the local variables, fix and split the
function prototype over multiple lines, remove the spaces around the
if condition, ...)
IMO better if you send a v2 with the cleanups after Wine 2.0.



More information about the wine-devel mailing list